Think about it: when you say 1-for-1, it actually doesn’t indicate any discount. You will buy one item and they will give you one item!

The correct way to say it should be “2 for the price of 1” or “Buy 1, get 1 free”.